Skip to content

chore: set libdde-shell.so SOVERSION to 1 #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BLumia merged 1 commit into from
Jun 16, 2025
Merged

chore: set libdde-shell.so SOVERSION to 1 #1160

BLumia merged 1 commit into from
Jun 16, 2025

Conversation

@BLumia
Copy link
Member

@BLumia BLumia commented Jun 16, 2025 •
edited by sourcery-ai bot
Loading

To separate version for other components and ABI version of libdde-shell.so

旨在允许任意 bump 打包时的版本号，避免需要各个依赖 libdde-shell.so 的项目 rebuild...

Summary by Sourcery

Enhancements:

  • Set libdde-shell.so SOVERSION to 1 to decouple the library's ABI version from the project version

@BLumia
chore: set libdde-shell.so SOVERSION to 1
b607a55 
To separate version for other components and ABI version of
libdde-shell.so

Log:
@BLumia BLumia requested review from 18202781743 and Zeno-sole June 16, 2025 02:59
@deepin-ci-robot
Copy link

deepin-ci-robot commented Jun 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@BLumia BLumia marked this pull request as ready for review June 16, 2025 03:00
@deepin-ci-robot
Copy link

deepin-ci-robot commented Jun 16, 2025

deepin pr auto review

关键摘要:

  • SOVERSION 从 ${CMAKE_PROJECT_VERSION_MAJOR} 改为 1 可能会影响动态链接库的兼容性，需要确认是否有意为之。

是否建议立即修改:

  • 是，如果这个改动是无意的，应该立即修复以避免潜在的兼容性问题。
  • 否，如果这个改动是有意为之，并且已经经过充分测试，可以保留。

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 16, 2025 •
edited
Loading

Reviewer's Guide

This PR decouples the ABI version of libdde-shell.so from the project version by hardcoding its SOVERSION to 1 in the CMake configuration.

File-Level Changes

Change Details Files
Decouple library ABI version from project version by setting a fixed SOVERSION
  • Replaced ${CMAKE_PROJECT_VERSION_MAJOR} with a constant 1 for the SOVERSION property
 frame/CMakeLists.txt
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jun 16, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BLumia - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin-ci-robot commented Jun 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 4babbff into linuxdeepin:master Jun 16, 2025
7 of 10 checks passed
@BLumia BLumia deleted the soversion branch June 16, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@18202781743 18202781743 18202781743 approved these changes

@Zeno-sole Zeno-sole Awaiting requested review from Zeno-sole

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BLumia @deepin-ci-robot @18202781743